fix: respect AbortSignal in run() - throw on abort instead of silently returning#376
Open
ctonneslan wants to merge 1 commit intoreplicate:mainfrom
Open
fix: respect AbortSignal in run() - throw on abort instead of silently returning#376ctonneslan wants to merge 1 commit intoreplicate:mainfrom
ctonneslan wants to merge 1 commit intoreplicate:mainfrom
Conversation
… abort run() ignores AbortSignal in two ways: 1. If signal is already aborted before calling run(), the prediction starts anyway instead of throwing immediately 2. If signal becomes aborted during polling, run() cancels the prediction but returns the result instead of throwing AbortError Now checks signal.aborted before starting the prediction and throws AbortError after cancellation instead of silently returning output. The cancel call is wrapped in catch to handle cases where the prediction already completed on Replicate's servers. Fixes replicate#370
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
replicate.run()ignoresAbortSignalin two ways:Pre-aborted signal: If
signal.abortedis alreadytruebefore callingrun(), the SDK starts the prediction anyway instead of throwing immediately.Mid-poll abort: If the signal becomes aborted during polling,
run()stops polling and cancels the prediction, but then silently returns instead of throwingAbortError. The caller has no way to distinguish between a successful completion and a cancelled request.Fix
Before starting: Check
signal.abortedand throwAbortErrorimmediately if already aborted.After cancellation: Throw
AbortErrorinstead of returning the prediction output. Thepredictions.cancel()call is wrapped in.catch()to handle cases where the prediction already completed on Replicate's servers.This matches how
fetch()handlesAbortSignaland allows callers to properly distinguish cancelled requests from completed ones.Fixes #370